Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove reference to Node 10+ req for create #881

Merged

Conversation

agilgur5
Copy link
Collaborator

Description

  • TSDX itself has a Node 10 requirement on package.json#engines now,
    so this is fairly explicit already and not limited to tsdx create
    anymore either

  • Node 8 was also EoL quite a while ago at the end of last year, so this
    isn't quite as important of a note anymore

Tags

Follow-up to #678 where I think I decided to leave it in for some reason, but I didn't comment why so I don't remember.

Removes a doc entry from #433

- TSDX itself has a Node 10 requirement on package.json#engines now,
  so this is fairly explicit already and not limited to `tsdx create`
  anymore either

- Node 8 was also EoL quite a while ago at the end of last year, so this
  isn't quite as important of a note anymore
@agilgur5 agilgur5 added scope: docs Documentation could be improved. Or changes that only affect docs topic: Node 10+ requires Node 10+ labels Sep 21, 2020
@vercel
Copy link

vercel bot commented Sep 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/1s2mqhx69
✅ Preview: https://tsdx-git-fork-agilgur5-docs-remove-create-node-10-ref.formium.vercel.app

Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agilgur5 agilgur5 merged commit a95d2d8 into jaredpalmer:master Sep 21, 2020
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
- TSDX itself has a Node 10 requirement on package.json#engines now,
  so this is fairly explicit already and not limited to `tsdx create`
  anymore either

- Node 8 was also EoL quite a while ago at the end of last year, so this
  isn't quite as important of a note anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs Documentation could be improved. Or changes that only affect docs topic: Node 10+ requires Node 10+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant